Use CLOCK_BOOTTIME also for amd64's time.now() in Go runtime #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason A. Donenfeld <[email protected]>
This change was missing in the original patch causing issues with GoLang time functions on chromebooks after device wakes up from sleep and leading to failed connections. Signed-off-by: Mateusz Markowicz <[email protected]>
mateusz-markowicz
force-pushed
the
boottime-fix-arm64
branch
from
465aa18 to
7a0e248
Compare
|
@zx2c4 you guys might find this interesting, without it wireguard-android is pretty much unusable on x86_64 (on chromebooks) |
zx2c4-bot
force-pushed
the
master
branch
3 times, most recently
from
91cdc96 to
57bd0ec
Compare
|
I think we're already doing this in the latest upstream master. (I'll make an app release soon.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was missing in the original patch causing issues with GoLang time functions on chromebooks after device wakes up from sleep and leading to failed connections.
After running below code on Chromebook after it was sleeping since boot
elapsed will have a difference between CLOCK_MONOTONIC and CLOCK_BOOTTIME which is the time device was sleeping since boot. It should be reproducible on any device with arm64 and where CLOCK_MONOTONIC and CLOCK_BOOTTIME can give different values. This behavior leads to incorrectly testing expiry for keypairs and consequently failed connections.
Issue seems to be reported here:
https://www.reddit.com/r/chromeos/comments/r2t1x4/chromeos_update_breaks_wireguard_android_vpn_apps/